Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change docker hub user #1145

Merged
merged 1 commit into from
Sep 24, 2024
Merged

change docker hub user #1145

merged 1 commit into from
Sep 24, 2024

Conversation

pirlodog1125
Copy link
Contributor

@pirlodog1125 pirlodog1125 commented Sep 24, 2024 •
edited by github-actions bot
Loading

User description

fix CI fail

Error response from daemon: Get "https://registry-1.docker.io/v2/": unauthorized: incorrect username or password
Error: Process completed with exit code 1.

PR Type

configuration changes

Description

  • GitHub Actionsのワークフローで使用されるDocker Hubユーザー名をyasukexxxから073722781018412843238584254322に変更しました。
  • この変更により、CIの失敗を修正します。

Changes walkthrough 📝

Relevant files
Configuration changes
docker-publish.yml
Update Docker Hub user in GitHub Actions workflow               

.github/workflows/docker-publish.yml

  • Docker Hub user changed from yasukexxx to
    073722781018412843238584254322.
    		•  +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @pirlodog1125 pirlodog1125 self-assigned this Sep 24, 2024
    @github-actions GitHub Actions
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    @github-actions GitHub Actions
    Copy link

    github-actions bot commented Sep 24, 2024 •
    edited
    Loading

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    DOCKERHUB_USER の値を適切なユーザー名に修正する。

    DOCKERHUB_USER
    の値が非常に長く、ランダムな数字の文字列になっています。これは誤っている可能性があります。通常、ユーザー名はわかりやすい名前であるべきです。適切なユーザー名に修正してください。

    .github/workflows/docker-publish.yml [19]

    -DOCKERHUB_USER: 073722781018412843238584254322
+DOCKERHUB_USER: your_dockerhub_username
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies that the DOCKERHUB_USER value appears to be a random string of numbers, which is likely incorrect for a username. Changing it to a more appropriate username improves clarity and correctness.

    		9

    @pirlodog1125 pirlodog1125 merged commit b8c2176 into master Sep 24, 2024
    7 checks passed
    @pirlodog1125 pirlodog1125 deleted the change-docker-hub-user branch September 24, 2024 04:36
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees

    @pirlodog1125 pirlodog1125

    Labels
    Configuration changes Review effort [1-5]: 1
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @pirlodog1125